feat(tests): overhaul staging test infrastructure and update fixtures by tychtjan · Pull Request #1392 · gooddata/gooddata-python-sdk

tychtjan · 2026-03-05T15:38:30Z

Summary

Added staging test support (PYTHON_DEX), which required rewrites in the test
infrastructure (dynamic PostgreSQL URL replacement instead of duplicating fixtures)
and a new CI workflow for pre-merge staging tests.

Changes by commit

1. `chore: regenerate API client from updated OpenAPI spec`

Updated OpenAPI-generated API client with new models and endpoints
Reviewer: auto-generated, safe to skip

2. `feat(ci): add staging test infrastructure and harden test setup`

Add staging-tests.yaml workflow (triggered by label, /test-staging comment, or manual dispatch)
Overhaul conftest.py for dynamic data source URL replacement (staging vs local)
Add clean_staging.py and upload_demo_layout.py helper scripts
Unify token passing: all staging make targets use TOKEN= argument
Fix LLM provider patch to use InAttributes after spec removed PatchAttributes
Add alternativeDataSourceId to data source fixture
Document staging test workflow in CONTRIBUTING.md

3. `chore: regenerate test cassettes`

Regenerated all cassettes against staging environment
Reviewer: regenerated fixtures, safe to skim

Test plan

Passes local tests
Passes staging environment tests

JIRA: DX-431
risk: low

codecov · 2026-03-05T15:42:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.53%. Comparing base (46c0f4b) to head (038dfb9).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1392      +/-   ##
==========================================
- Coverage   77.53%   77.53%   -0.01%     
==========================================
  Files         225      225              
  Lines       14614    14613       -1     
==========================================
- Hits        11331    11330       -1     
  Misses       3283     3283

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

.github/workflows/staging-tests.yaml

hkad98 · 2026-03-05T20:29:17Z

.github/workflows/staging-tests.yaml

+      - name: Clean staging environment
+        run: make clean-staging TOKEN=${{ secrets.PYTHON_SDK_STG_API_KEY }}


Suggested change

- name: Clean staging environment

run: make clean-staging TOKEN=${{ secrets.PYTHON_SDK_STG_API_KEY }}

- name: Clean staging environment

run: make clean-staging

env:

TOKEN: ${{ secrets.PYTHON_SDK_STG_API_KEY }}

Either use secrets in env or with.

tychtjan · 2026-03-12T08:31:04Z

I analyzed why there were some of the bigger deletes in the fixtures

 # OLD: cleanup + verification assertion
  finally:
      sdk.catalog_organization.delete_jwk("demoJwk")
      assert len(sdk.catalog_organization.list_jwks()) == 0  # <-- this GET is now gone

The new pattern uses safe_delete() which only calls the delete, no verification list:

  # NEW: cleanup only, no verification
  finally:
      safe_delete(sdk.catalog_organization.delete_jwk, "demoJwk")

This removes the final GET ...?page=0&size=500 call that verified the entity was gone.
That's why every cassette has a trailing interaction block removed — it was the VCR recording of
that verification GET. This is entirely expected and correct. The verification was fragile on staging (where other entities may exist, making len(...) == 0 fail), and the safe_delete + snapshot/restore approach is more robust.

- Add staging test workflow and configuration - Overhaul test conftest and catalog test files for staging support - Add docker-compose env vars, clean_staging and upload_demo_layout scripts - Fix LLM provider patch to use InAttributes after spec change - Add alternativeDataSourceId to data source fixture - Fix docs CI (toml dep, stale artifacts, baseURL, Hugo caching) - Add docs API reference pre-rendering and tests - Add AIDA onboarding artifacts

hkad98 · 2026-03-12T09:43:22Z

.github/workflows/staging-tests.yaml

+      - name: Install dependencies
+        run: uv sync --all-groups --locked


This is too broad. Consider checking out .github/workflows/rw-python-tests.yaml and unit-tests.

Fixed to run: uv sync --group test --locked

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

tychtjan requested review from hkad98, jaceksan, lupko and pcerny as code owners March 5, 2026 15:38

hkad98 reviewed Mar 5, 2026

View reviewed changes

.github/workflows/staging-tests.yaml Outdated Show resolved Hide resolved

hkad98 reviewed Mar 5, 2026

View reviewed changes

.github/workflows/staging-tests.yaml Outdated Show resolved Hide resolved

hkad98 reviewed Mar 5, 2026

View reviewed changes

tychtjan force-pushed the tests_rewrite_staging branch from 44844f3 to 54e15b1 Compare March 12, 2026 07:59

tychtjan force-pushed the tests_rewrite_staging branch from 7a6168a to b8b6a13 Compare March 12, 2026 09:16

tychtjan added 3 commits March 12, 2026 10:18

chore: regenerate API client from updated OpenAPI spec

202d78c

chore: regenerate test cassettes

d2e0811

tychtjan force-pushed the tests_rewrite_staging branch from b8b6a13 to d2e0811 Compare March 12, 2026 09:19

hkad98 reviewed Mar 12, 2026

View reviewed changes

fix(ci): narrow staging workflow dependencies to test group only

038dfb9

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(tests): overhaul staging test infrastructure and update fixtures#1392

feat(tests): overhaul staging test infrastructure and update fixtures#1392
tychtjan wants to merge 4 commits intomasterfrom
tests_rewrite_staging

tychtjan commented Mar 5, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

hkad98 Mar 5, 2026 •

edited

Loading

Uh oh!

tychtjan commented Mar 12, 2026 •

edited

Loading

Uh oh!

hkad98 Mar 12, 2026

Uh oh!

tychtjan Mar 12, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		- name: Clean staging environment
		run: make clean-staging TOKEN=${{ secrets.PYTHON_SDK_STG_API_KEY }}

		- name: Install dependencies
		run: uv sync --all-groups --locked

Conversation

tychtjan commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes by commit

1. chore: regenerate API client from updated OpenAPI spec

2. feat(ci): add staging test infrastructure and harden test setup

3. chore: regenerate test cassettes

Test plan

Uh oh!

codecov bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

hkad98 Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tychtjan commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hkad98 Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

tychtjan Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tychtjan commented Mar 5, 2026 •

edited

Loading

1. `chore: regenerate API client from updated OpenAPI spec`

2. `feat(ci): add staging test infrastructure and harden test setup`

3. `chore: regenerate test cassettes`

codecov bot commented Mar 5, 2026 •

edited

Loading

hkad98 Mar 5, 2026 •

edited

Loading

tychtjan commented Mar 12, 2026 •

edited

Loading

tychtjan Mar 12, 2026 •

edited

Loading